modern browsers eat first newline in textarea. #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| text = node.text[1:] | ||
| else: | ||
| text = node.text | ||
| attrs['value'] = text |
There was a problem hiding this comment.
Shouldn't we just do node.text.strip()?
There was a problem hiding this comment.
Nо, we don`t want to delete last newlines chars, and the second newline from begining of the node.text. But strip removes all whitespaces (space, tab, \b) from start and end of the string
There was a problem hiding this comment.
this removes \r\r\r\r\r\r\r or \r\n\r\n\r\n\r\n or \n\n\n\n\n\n\n\n or \n\r\r\r\r\r\n\r\n\r
|
Could you add a changelog entry? Thanks! |
|
I added |
domenkozar
added a commit
that referenced
this pull request
May 4, 2013
modern browsers eat first newline in textarea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modern browsers eat first empty line in textarea block.
see https://code.djangoproject.com/ticket/8627
so when we parse form, we need to remove leading newline char in textarea block.
My tests broken after I started to migrate to django 1.5 branch, I use webtest to functional testing.
Also please note, that it only affects html.parser beautufulsoup builder. because in html5lib leading newline removed automaticly https://github.com/html5lib/html5lib-python/blob/master/html5lib/html5parser.py#L993.