Deprecate ?demostorage in favour of demo:// #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 2021 in 2f02bc9 (demo: URI resolver) we added support for generic demo:// URI scheme which allows combining any two storages into a DemoStorage. This support is more generic because e.g. previously ?demostorage was provided only by file:// and zeo:// URI schemes, with the "changes" part there being hardcoded to in-memory MappingStorage. Now there is no need to use ?demostorage option as we can use demo:// uniformly. Deprecating ?demostorage in favour of dedicated DemoStorage resolver was actually suggested several times in the past: Pylons#25 (comment) Pylons#25 (comment) Pylons#25 (comment)
stevepiercy
approved these changes
May 24, 2023
|
Thanks, @stevepiercy. In the past I was granted zodburi maintaintership together with @azmeuk, so I think it should be enough if Éloi reviews this. I would be glad to be proven wrong, but in my experience Jim, Tres and Chris are no longer active in around ZODB. |
tseaver
reviewed
May 24, 2023
@tseaver suggests at Pylons#33 (review) : Rather than removing the docs, please flag this option as deprecated (likewise below). -> Restore documentation and add (deprecated in favour of ``demo:`` URI scheme) notice.
tseaver
approved these changes
May 25, 2023
|
Thanks, @tseaver. |
|
With 2 approvals I think it is ok to merge this patch. I plan to do so in a day or two. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 2021 in 2f02bc9 (demo: URI resolver) we added support for generic demo:// URI scheme which allows combining any two storages into a DemoStorage. This support is more generic because e.g. previously ?demostorage was provided only by file:// and zeo:// URI schemes, with the "changes" part there being hardcoded to in-memory MappingStorage.
Now there is no need to use ?demostorage option as we can use demo:// uniformly.
Deprecating ?demostorage in favour of dedicated DemoStorage resolver was actually suggested several times in the past:
#25 (comment)
#25 (comment)
#25 (comment)
/cc @azmeuk, @stevepiercy