Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve errors in LaTeX printer for set operations / multidimensional sets #3177

Merged
merged 11 commits into from
Mar 7, 2024

Conversation

jsiirola
Copy link
Member

@jsiirola jsiirola commented Mar 5, 2024

Fixes # .

Summary/Motivation:

This resolves errors in the latex_printer() for models with set operators (in particular, SetProduct indexing sets) and multidinensional sets.

Changes proposed in this PR:

  • minor performance improvements in internal lookups
  • resolve errors naming IndexTemplate objects for multidimensionsl sets
  • resolve overlapping placeholder IDs for models with > 10 vars or params
  • pull out some embedded constants (make it easier to override)
  • Improved output of anonymous set expressions
  • add test of pmedian (which motivated these changes)

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

Copy link
Contributor

@mrmundt mrmundt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this do anything to address issues reported in #3121 ?

@mrmundt
Copy link
Contributor

mrmundt commented Mar 5, 2024

NEOS is having some issues today, it appears.

@jsiirola
Copy link
Member Author

jsiirola commented Mar 6, 2024

Does this do anything to address issues reported in #3121 ?

Nope: #3121 is asking for support of block structured models That will be a separate PR (this is addressing indexing issues.

@jsiirola
Copy link
Member Author

jsiirola commented Mar 7, 2024

Coverage failure is a codecov issue: the latex_printer is covered at over 92%,

@jsiirola jsiirola merged commit 3a43b40 into Pyomo:main Mar 7, 2024
32 of 33 checks passed
@jsiirola jsiirola deleted the latex-multi-dim branch March 7, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants