Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating PySP tests #788

Merged
merged 8 commits into from
Dec 19, 2018
Merged

Updating PySP tests #788

merged 8 commits into from
Dec 19, 2018

Conversation

jsiirola
Copy link
Member

Summary/Motivation:

This should resolve the last of the failing tests in Jenkins (Pyomo_trunk). This PR requires PyUtilib/pyutilib#47.

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@jsiirola jsiirola changed the title Updatign PySP tests Updating PySP tests Dec 19, 2018
@codecov-io
Copy link

Codecov Report

Merging #788 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #788      +/-   ##
==========================================
- Coverage   66.92%   66.91%   -0.01%     
==========================================
  Files         421      421              
  Lines       66713    66713              
==========================================
- Hits        44646    44644       -2     
- Misses      22067    22069       +2
Impacted Files Coverage Δ
pyomo/pysp/ph.py 61.15% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e69d6b...582789b. Read the comment docs.

Copy link
Member

@blnicho blnicho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks fine, just minor changes to PySP tests. It would be great to have a PySP developer take a quick look at this before merging but I don't think it's absolutely required since we discussed these changes with them at the Pyomo dev meeting yesterday.

@ghackebeil ghackebeil merged commit 1fa7061 into Pyomo:master Dec 19, 2018
@jsiirola jsiirola deleted the pysp-fragile branch December 19, 2018 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants