-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating PySP tests #788
Updating PySP tests #788
Conversation
This is enabled by a fix to PyUtilib's numeric comparisons to support both absolute and relative tolerances (PyUtilib/pyutilib#47).
Codecov Report
@@ Coverage Diff @@
## master #788 +/- ##
==========================================
- Coverage 66.92% 66.91% -0.01%
==========================================
Files 421 421
Lines 66713 66713
==========================================
- Hits 44646 44644 -2
- Misses 22067 22069 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks fine, just minor changes to PySP tests. It would be great to have a PySP developer take a quick look at this before merging but I don't think it's absolutely required since we discussed these changes with them at the Pyomo dev meeting yesterday.
Summary/Motivation:
This should resolve the last of the failing tests in Jenkins (Pyomo_trunk). This PR requires PyUtilib/pyutilib#47.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: