Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allowShades property #5

Merged
merged 6 commits into from
Jan 27, 2019
Merged

Add allowShades property #5

merged 6 commits into from
Jan 27, 2019

Conversation

stanchanpsu
Copy link
Contributor

@stanchanpsu stanchanpsu commented Jan 24, 2019

This allows the user to choose if they want shades to be allowed at all. Defaults to true.
Also controls the onColorChange callback, which can't be used in conjunction with allowShades: false. Users would use only onMainColorChange instead.

I can update the docs and change list if you accept this PR.

@stanchanpsu stanchanpsu changed the title Remove premature call to onColorChange Add allowShades property Jan 25, 2019
@stanchanpsu stanchanpsu changed the title Add allowShades property Add allowShades property Jan 25, 2019
@Pyozer Pyozer merged commit cdd87f0 into Pyozer:master Jan 27, 2019
@NBTX
Copy link

NBTX commented Jan 28, 2019

Perfect! Thanks.

@fregate fregate mentioned this pull request Aug 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants