Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allowImplicitScrolling parameter to IntroductionScreen widget #138

Merged
merged 4 commits into from Dec 24, 2022

Conversation

HussainTaj-W
Copy link
Contributor

This PR adds a new boolean parameter allowImplicitScrolling to IntroductionScreen widget to be used in the PageView widget.

For details about what this parameter does, you may consult the documentation here.

I had to add this parameter to solve this problem. However, I believe it might be useful in some other cases as well.

@ghenry
Copy link
Collaborator

ghenry commented Nov 23, 2022

Hi @HussainTaj-W

I've merged some earlier PRs and this is now in conflict. Would you mind revisiting this on a fresh fork? That would be very kind of you if you could and thanks for taking the time to do this for the benefit of others.

Many thanks,
Gavin.

@ghenry ghenry mentioned this pull request Nov 23, 2022
@HussainTaj-W
Copy link
Contributor Author

@ghenry I've updated this PR.

@ghenry ghenry merged commit 932a38e into Pyozer:master Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants