Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

breaking -> turn _currentpage into an int instead of double #180

Merged
merged 2 commits into from May 30, 2023
Merged

breaking -> turn _currentpage into an int instead of double #180

merged 2 commits into from May 30, 2023

Conversation

Macacoazul01
Copy link
Contributor

No description provided.

@Macacoazul01
Copy link
Contributor Author

@ghenry i've removed 2 setstate that don't seem necessary.

Can you check if they are, before merging?

Tested and everything went fine.

@Macacoazul01
Copy link
Contributor Author

Macacoazul01 commented May 6, 2023 •
edited

This pr doesn't contain the fixes from #178

@ghenry
Copy link
Collaborator

ghenry commented May 6, 2023 via email

@Macacoazul01
Copy link
Contributor Author

@ghenry any chances of reviewing this week?

@ghenry ghenry merged commit 5f96b77 into Pyozer:master May 30, 2023
2 checks passed
@Macacoazul01 Macacoazul01 mentioned this pull request Jun 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pyozer Pyozer Pyozer left review comments

@koutja koutja koutja left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Macacoazul01 @ghenry @Pyozer @koutja