Minor wording issue when Leonaria joins the party

[macce2]

When Leonaria is added to the group,
she still says: "I hope you visit me soon..".
Maybe this minor flaw should be corrected.
I guess this also concerns the original Ambermoon;
but I added this here, because I found this
playing the Advanced version. Sorry.

[a1exh]

Good find.

NPCs & PCs have a text string they say when you push the "recruit button"

e.g. EGIL says "I WILL JUST GET MY THINGS, THEN WE CAN START!"

They also have another text string they say when you press EXIT.

e.g. CLEMENTINE says "HAVE A NICE DAY!"

Somehow Leonaria's are the same?

This should be an easy fix.

[Pyrdacor]

In general the party members will say the same text regardless of if they are in your party or not.

I think other party members are affected as well. Maybe Gryban is an exception now as I extended him for the second episode.

In general we would have to add some logic to switch between texts if someone is inside the party. But there is more to consider. Egil for example will always talk about handling the bandits and orcs even though you have completed this. Sabine will talk about Luminor etc.

If we start, we should do it properly for all party members.

[Pyrdacor]

There are certain flags which represent some quest progress. So it will be possible to change the texts at the right time. But this will require new texts in all the supported languages of course. Most can be rather short I guess.

[Pyrdacor]

I moved this to the Ambermoon repo as it is a problem for the original game as well.

[a1exh]

@Pyrdacor are you sure this is how it works? I think all the logic for this should already be in the game, there is just a mistake in one sub-file?

The texts are stored in Party_texts.amb EGIL is sub-file 8. LEONARIA is sub-file 14

It is clear (to me) that when you press the recruit button LEONARIA is supposed to display the text

"MMHH, IT IS TRUE THAT I AM LOOKING TO JOIN A GROUP AT THE MOMENT. I THINK THAT AS AN ALCHEMIST I COULD BE QUITE USEFUL TO YOU. VERY WELL, I WILL JOIN YOU!"

I think there is one too many strings in the LEONARIA subfile? She seems to have two "EXIT" messages. "FAREWELL!" and "I HOPE YOU WILL VISIT ME AGAIN SOON." Maybe combine the two and this will fix it?

[Edit] That said other PCs have different numbers of strings so maybe this isn't 100% the issue?

[macce2]

The text data concerning the Elf landlord (tavern keeper) should also be corrected accordingly.

[a1exh]

The text data concerning the Elf landlord (tavern keeper) should also be corrected accordingly.

I don't understand this part of the bug report. There's not enough information in it and how it relates to what was already reported. If it's a completely unrelated event it should be a separate bug report. Try and post the text displayed and how a bug is triggered in your bug reports.

[Pyrdacor]

@a1exh I think there is a misunderstanding here. It is not about Leonaria using her "exit text" when you try to recruit her. It's about leaving the conversation while she is already in your party. Then she still says "I hope you visit me soon" when you exit but she is with you. This is no wrong text or event. There is just this one exit text which is always used. The other text "Farewell" is most likely the "Leave party" text.

So the solution here is to check if Leonaria is in your party and use another exit message in that case. Something like "I'll talk to you later" etc.

[Pyrdacor]

In general it's about NPCs use the same texts even though they should know better (are with you, know that something changed, etc). This is a problem with many NPCs throughout the whole game. Most NPCs have a fixed text set. Sometimes they have additional texts after quest completion or when you talk to them for the second time but that's it. They usually don't react to other game progress related world changes. I did this a bit more in the Advanced version but mostly with new NPCs or NPCs which have new quests.

[Pyrdacor]

I will delete the messages. You should only answer to the GitHub mails if you want to continue the discussion here.

Regarding the name of the Flight spell. We discussed this here: #31

Unfortunately I used the old name in the Ambermoon Advanced manual.