For topics improvements branch #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support async natively using manifold to get error bubbling. Support topic seeking, both simple and on a per-partition basis. Support throwing errors for both server side returned values and errors internal to the networking stack. Unified config map usable with all client methods.
lbradstreet
reviewed
Oct 19, 2017
README.md
Outdated
|
|
||
| #### Send a batch of events asynchronously | ||
| ;; Subscribe to a topic, registering a new Consumer Group | ||
| (def consumer-instance-map @(client/topic-subscribe config "my-consumer-group")) |
There was a problem hiding this comment.
Lets rename consumer-instance-map to consumer-instance? I think it's fine to make topic-subscribe block so they don't have deref too. It's not like the consumer can do anything in the mean time?
lbradstreet
reviewed
Oct 19, 2017
README.md
Outdated
| ;; | ||
| ;; Poll the topic using the consumer instance map returned from topic-subscribe. | ||
| ;; Note that JSON records are returned. | ||
| @(client/topic-consumer-poll! config consumer-instance-map) |
There was a problem hiding this comment.
Dereffable polls are fine tho. What if you get re-ordering of requests when going async though? I guess we can add some queuing/re-ordering at the client level later.
…to develop * 'develop' of github.com:PyroclastIO/pyroclast-clojure: Add additional seek to the beginning test. Better error response handling / messages.
them in `common-response`.
and consumer-instance-map to read functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework API to be more consistent and universally include docstrings.
Support async natively using manifold to get error bubbling.
Support topic seeking, both simple and on a per-partition basis.
Support throwing errors for both server side returned values and
errors internal to the networking stack.
Unified config map usable with all client methods.