Retry when we get a generic LLM API error. #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reworked the PR so we alway auto-retry up to max retries (3). If that fails, we ask the user if they want to retry again, in which case we again retry up to 3 times, then ask again, etc. If the user declines, we raise APIError which stops Pythagora:
(between each of the "do you want to retry" there's 3 retries underneath) |
|
LGTM, can't merge as it still has me as an author, 🚢 |
|
@LeonOstrez since Goran and me collaborated on this, it falls to you as an independent party to review :) |
senko
force-pushed
the
retry-generic-llm-error
branch
from
5f62fd3
to
80e5e32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ask the user to retry when we get
{LLM Provider}.APIerrorexception.