Freeze dictionary keys to make them hashable

[nielstron]

Alternative solution for #227

[nielstron]

This should fix OpShin/opshin-pioneer-program#43

[nielstron]

Only codecov failed uploading, possibly due to the CI being incorrectly set up

[juliusfrost]

It looks like there's double recursion in _freeze and _helper, which squares the search depth. Maybe merge the two to freeze just the outer data type, since we can assume the inner values are already frozen.

[cffls]

This is awesome! 🚀

[nielstron]

It looks like there's double recursion in _freeze and _helper, which squares the search depth. Maybe merge the two to freeze just the outer data type, since we can assume the inner values are already frozen.

You're right, the Seth elements and dictionary keys do not need to be frozen again, they can be assumed to be frozen.

A frozenhelper function also sounds interesting 🤔

[codecov-commenter]

Codecov Report

Merging #228 (ddb6b93) into main (da6da64) will decrease coverage by 0.17%.
The diff coverage is 65.78%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #228      +/-   ##
==========================================
- Coverage   85.73%   85.56%   -0.17%     
==========================================
  Files          26       26              
  Lines        2923     2952      +29     
  Branches      701      707       +6     
==========================================
+ Hits         2506     2526      +20     
- Misses        307      314       +7     
- Partials      110      112       +2     

Impacted Files	Coverage Δ
pycardano/serialization.py	84.61% <65.78%> (-2.32%)	⬇️

... and 3 files with indirect coverage changes

[juliusfrost]

I'm looking at this again from my computer (as opposed to my phone), I think I meant to say merge _dfs with _frozen

[juliusfrost]

@nielstron I made a quick edit here: OpShin#3

[juliusfrost]

This might be a good opportunity to use hypothesis to generate arbitrary CBORSerializable types

[juliusfrost]

If we don't want to freeze all the time we could set a freeze argument and only freeze when true, then set it true recursively for keys but default false otherwise

[juliusfrost]

If we don't want to freeze all the time we could set a freeze argument and only freeze when true, then set it true recursively for keys but default false otherwise

I implemented this here: OpShin#4

[juliusfrost]

OpShin#5
Fixes TypeError: unhashable type: 'list'

[juliusfrost]

This recent PR in frozendict fixes the mypy issue when I tested it locally. Hope they make a new release soon

[juliusfrost]

OpShin#6 fixes issues with poetry run mypy --install-types --non-interactive pycardano

[juliusfrost]

@cffls This should be ready to merge :)

[cffls]

Awesome, thanks! LGTM.