Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade GitHub Actions #14

Merged

Conversation

AdrianDsg
Copy link
Contributor

@AdrianDsg AdrianDsg commented Dec 7, 2023

Hi,
I just discovered this interesting project. I noticed that the GitHub Actions used in the CI workflows are outdated since a while.

Due to the use of the outdated Node.js version 12 some will break eventually.

Screenshot of actions warnings

I upgraded the GitHub Actions to the latest versions.

I also noticed that the GitHub host is harcoded in:

URL_BASE = 'https://github.com'

Therefore usage on GitHub Enterprise Servers (GHES) is currently unfortunately not possible. Adding a new config item might fix it.

'user': ['', 'GitHub user or organization.'],
'repo': ['', 'Repository name.']

    'hostname': ['github.com', 'GitHub Enterprise Server hostname.']

The hostname would be parsed afterwards and used in URL_BASE.

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master@5bc28d3). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff             @@
##             master       #14   +/-   ##
==========================================
  Coverage          ?   100.00%           
==========================================
  Files             ?         2           
  Lines             ?       123           
  Branches          ?         0           
==========================================
  Hits              ?       123           
  Misses            ?         0           
  Partials          ?         0           
Flag Coverage Δ
unittests 100.00% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waylan waylan merged commit 24242b5 into Python-Markdown:master Dec 8, 2023
25 checks passed
@waylan
Copy link
Member

waylan commented Dec 8, 2023

Thank you for the update.

I also noticed that the GitHub host is harcoded in:

Therefore usage on GitHub Enterprise Servers* (GHES) is currently unfortunately not possible. Adding a new config item might fix.

Please feel free to submit a PR to address this. Or, if you are not able to do so, then please open a new issue so I don't forget about it.

@AdrianDsg AdrianDsg deleted the adriandsg/upgrade-dependencies branch December 11, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants