Ensure permalinks and ankorlinks are not restricted by toc_depth #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a regression which was introduced with support for toc_depth. Relevant tests have been moved and updated to the new framework. Fixes Python-Markdown#1107. The test fraamework also received an addition. The assertMarkdownRenders method now accepts a new keyword expected_attrs which consists of a dict of attrs and expected values. Each is checked against the attr of the Markdown instance. This was needed to check the value of md.toc and md.toc_tokens in some of the included tests.
This was referenced Feb 24, 2021
Phuker
added a commit
to Phuker/md2html
that referenced
this pull request
Aug 26, 2021
Note: Python-Markdown, 2021-2-24, version 3.3.4 changes: Ensure permalinks and ankorlinks are not restricted by toc_depth Python-Markdown/markdown#1108
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression which was introduced with support for
toc_depth.Relevant tests have been moved and updated to the new framework.
Fixes #1107.
The test framework also received an addition. The
assertMarkdownRendersmethod now accepts a new keyword
expected_attrswhich consists of a dictof attrs and expected values. Each is checked against the attr of the
Markdowninstance. This was needed to check the value ofmd.tocandmd.toc_tokensin some of the included tests.