Skip to content
This repository has been archived by the owner on Dec 22, 2023. It is now read-only.

Add Image-scrapper script #91

Closed
wants to merge 13 commits into from

Conversation

rohitjoshi6
Copy link
Contributor

Description

I want to add a Web-Scrapping script which scrapes images from URL.
Fixes #31

Type of change

Choosing one or more options from the following as per the nature of your Pull request.

  • NOTE: These boxes can be checked using [X]

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Documentation Update

Checklist:

Please tick all the boxes that are fulfilled by your Pull Request.

  • I have named my files and folder, according to this project's guidelines.
  • My code follows the style guidelines of this project.
  • My Pull Request has a descriptive title. (not a vague title like Update index.md)
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have created a helpful and easy to understand README.md, according to the given README_TEMPLATE.
  • I have included a requirements.txt file (if external libraries are required.)
  • My changes do not produce any warnings.
  • I have added a working sample/screenshot of the script.

Copy link
Member

@AdityaJ7 AdityaJ7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this script work only with the hardcoded URL?

If no then add a prompt to ask the user for a URL

Follow the functional programming paradigm and comment your code.

Copy link
Member

@tusharnankani tusharnankani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please fix the README errors.
  • Comment your code.
  • Avoid extra empty unnecessary lines on code.


# Pre-requisites:
#### Run the following command:
```python
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be bash instead of python

import random
import os

url="https://www.creativeshrimp.com/top-30-artworks-of-beeple.html"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Take URL as an input

Added Url as input feature
Added extra line after every heading #
@rohitjoshi6
Copy link
Contributor Author

I have added the requested feature of taking url as input and fixed the error in README.md file

Copy link
Member

@chavarera chavarera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot from 2020-10-01 22-38-08

@@ -0,0 +1,5 @@
requests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add appropriate module version using command

pip freeze list>requirements.txt

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add appropriate module version using command

pip freeze list>requirements.txt

You mean i should add version of the modules used in the requirements.txt file. right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its Showing that there's merge conflict. How can i solve this issue?

rohitjoshi6 and others added 2 commits October 1, 2020 23:24
Added version information of modules used
chavarera
chavarera previously approved these changes Oct 2, 2020
@chavarera chavarera dismissed their stale review October 2, 2020 11:34

conflict in merge

@rohitjoshi6
Copy link
Contributor Author

Can you delete this pull request? i will make a new pull request

@chavarera
Copy link
Member

Can you delete this pull request? i will make a new pull request

@rohitjoshi6 sure please make a new PR

@chavarera chavarera closed this Oct 3, 2020
@rohitjoshi6 rohitjoshi6 deleted the Scrapping branch October 3, 2020 06:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Submit your Python script ideas
4 participants