-
Notifications
You must be signed in to change notification settings - Fork 262
Conversation
Added required modules
Added img
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this script work only with the hardcoded URL?
If no then add a prompt to ask the user for a URL
Follow the functional programming paradigm and comment your code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please fix the README errors.
- Comment your code.
- Avoid extra empty unnecessary lines on code.
|
||
# Pre-requisites: | ||
#### Run the following command: | ||
```python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be bash
instead of python
import random | ||
import os | ||
|
||
url="https://www.creativeshrimp.com/top-30-artworks-of-beeple.html" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Take URL as an input
Added Url as input feature
Added extra line after every heading #
I have added the requested feature of taking url as input and fixed the error in README.md file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,5 @@ | |||
requests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add appropriate module version using command
pip freeze list>requirements.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add appropriate module version using command
pip freeze list>requirements.txt
You mean i should add version of the modules used in the requirements.txt file. right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its Showing that there's merge conflict. How can i solve this issue?
Added version information of modules used
minor change in readme file
Can you delete this pull request? i will make a new pull request |
@rohitjoshi6 sure please make a new PR |
Description
I want to add a Web-Scrapping script which scrapes images from URL.
Fixes #31
Type of change
Choosing one or more options from the following as per the nature of your Pull request.
NOTE: These boxes can be checked using
[X]
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Documentation Update
Checklist:
Please tick all the boxes that are fulfilled by your Pull Request.
Update index.md
)README.md
, according to the givenREADME_TEMPLATE.