Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed undefined variable children_hooks + imports cleanup #348

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

omit66
Copy link
Contributor

@omit66 omit66 commented Jul 17, 2018

Bugfix in function touch_import_top

current behavior:
It is not possible to create an new import without using from package.
If the parameter package of the function touch_import_top is None, the variable children_hooks is undefined.

expected behavior:
Setting package to None should create an import-statement.

changes:
children_hooks is used anyway, it should not be defined within an if-else statement.
Moved the definition.

Removed some reimports.

@lisroach
Copy link

Pinging this, we are running into this issue and would love to see it fixed.

@edschofield edschofield merged commit 515f611 into PythonCharmers:master Feb 21, 2024
@edschofield
Copy link
Contributor

Thanks @omit66 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants