Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extending openAPI #226

Merged
merged 64 commits into from Feb 15, 2021

Conversation

galzunited
Copy link
Contributor

@galzunited galzunited commented Feb 7, 2021

override the defaults with custom openAPI - self hosted css for future changes. as for now, refactored some of the apis and added new one so we could create user/events manually. excluded irrelevant apis from schema.

Copy link
Member

@yammesicka yammesicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Please fix the conflicts and have a look at my 2 minor comments :)

app/routers/dayview.py Outdated Show resolved Hide resolved
app/utils/extending_openapi.py Outdated Show resolved Hide resolved
gala added 3 commits February 9, 2021 11:11
# Conflicts:
#	app/main.py
#	app/routers/event.py
#	app/routers/invitation.py
#	app/routers/profile.py
#	app/routers/telegram.py
@yammesicka
Copy link
Member

Please solve the conflicts :)

gala added 2 commits February 11, 2021 21:13
# Conflicts:
#	app/routers/profile.py
#	app/templates/import_holidays.html
Copy link
Member

@yammesicka yammesicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there :)

app/routers/event.py Show resolved Hide resolved
gala added 3 commits February 13, 2021 11:20
@yammesicka
Copy link
Member

yammesicka commented Feb 14, 2021

I've fixed some conflicts in order to merge, but there are some errors - please have a look and fix it :)

https://github.com/PythonFreeCourse/calendar/pull/226/checks?check_run_id=1896171413

Copy link
Member

@yammesicka yammesicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job. I have some minor insights. This issue is ready to merge after fixing them.

app/routers/profile.py Outdated Show resolved Hide resolved
app/templates/import_holidays.html Outdated Show resolved Hide resolved
app/static/style.css Outdated Show resolved Hide resolved
app/static/style.css Outdated Show resolved Hide resolved
@yammesicka yammesicka merged commit 7df57c2 into PythonFreeCourse:develop Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants