New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: extending openAPI #226
feat: extending openAPI #226
Conversation
overrided the defaults with custom openAPI - self hosted css for future changes. as for now, refactored some of the apis and added new one so we could create user/events manually.
# Conflicts: # app/main.py
# Conflicts: # app/routers/profile.py # app/templates/profile.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Please fix the conflicts and have a look at my 2 minor comments :)
# Conflicts: # app/main.py # app/routers/event.py # app/routers/invitation.py # app/routers/profile.py # app/routers/telegram.py
Please solve the conflicts :) |
# Conflicts: # app/routers/profile.py # app/templates/import_holidays.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there :)
# Conflicts: # app/main.py # app/routers/dayview.py
I've fixed some conflicts in order to merge, but there are some errors - please have a look and fix it :) https://github.com/PythonFreeCourse/calendar/pull/226/checks?check_run_id=1896171413 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job. I have some minor insights. This issue is ready to merge after fixing them.
# Conflicts: # app/main.py # app/static/style.css
override the defaults with custom openAPI - self hosted css for future changes. as for now, refactored some of the apis and added new one so we could create user/events manually. excluded irrelevant apis from schema.