Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate color format of category in BE #251

Merged

Conversation

ivarshav
Copy link
Contributor

No description provided.

@ivarshav ivarshav mentioned this pull request Feb 10, 2021
Copy link
Member

@yammesicka yammesicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job! Again, added some minor comments :)

app/routers/categories.py Outdated Show resolved Hide resolved
app/routers/categories.py Outdated Show resolved Hide resolved
tests/test_categories.py Outdated Show resolved Hide resolved
tests/test_categories.py Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Feb 11, 2021

Codecov Report

Merging #251 (9bf6f63) into develop (5d0a09d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #251   +/-   ##
========================================
  Coverage    99.40%   99.40%           
========================================
  Files           47       47           
  Lines         2188     2199   +11     
========================================
+ Hits          2175     2186   +11     
  Misses          13       13           
Impacted Files Coverage Δ
app/routers/categories.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d0a09d...9bf6f63. Read the comment docs.

@yammesicka yammesicka merged commit 1b82ee2 into PythonFreeCourse:develop Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants