Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/separate vc link #263

Merged

Conversation

Michael-B-D
Copy link
Contributor

separate the VC link from the location in the frontend and in the DB

@codecov-io
Copy link

codecov-io commented Feb 11, 2021

Codecov Report

Merging #263 (069524b) into develop (9724685) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #263      +/-   ##
===========================================
+ Coverage    99.04%   99.06%   +0.01%     
===========================================
  Files           50       48       -2     
  Lines         2310     2251      -59     
===========================================
- Hits          2288     2230      -58     
+ Misses          22       21       -1     
Impacted Files Coverage Δ
app/database/models.py 96.64% <100.00%> (+0.02%) ⬆️
app/internal/event.py 100.00% <100.00%> (ø)
app/routers/event.py 97.29% <100.00%> (-0.02%) ⬇️
app/main.py 96.55% <0.00%> (-0.12%) ⬇️
app/routers/dayview.py 100.00% <0.00%> (ø)
app/routers/four_o_four.py
app/routers/weekview.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9724685...f635e16. Read the comment docs.

@@ -12,8 +12,8 @@
ZOOM_REGEX = re.compile(r'https://.*?\.zoom.us/[a-z]/.[^.,\b\s]+')


def raise_if_zoom_link_invalid(location):
if ZOOM_REGEX.search(location) is None:
def raise_if_zoom_link_invalid(vc_link):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add type annotations

@yammesicka yammesicka merged commit 8cd3a6e into PythonFreeCourse:develop Feb 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants