Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build/tox #264

Merged
merged 4 commits into from Feb 15, 2021
Merged

Build/tox #264

merged 4 commits into from Feb 15, 2021

Conversation

issac211
Copy link
Contributor

added tox config, markers and pytest config

added to the README testing Instructions

@codecov-io
Copy link

codecov-io commented Feb 11, 2021

Codecov Report

Merging #264 (d828a45) into develop (856c843) will decrease coverage by 0.01%.
The diff coverage is 97.18%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #264      +/-   ##
===========================================
- Coverage    99.06%   99.04%   -0.02%     
===========================================
  Files           48       50       +2     
  Lines         2251     2310      +59     
===========================================
+ Hits          2230     2288      +58     
- Misses          21       22       +1     
Impacted Files Coverage Δ
app/routers/event.py 97.31% <ø> (ø)
app/main.py 96.66% <50.00%> (+0.11%) ⬆️
app/routers/four_o_four.py 85.71% <85.71%> (ø)
app/routers/dayview.py 100.00% <100.00%> (ø)
app/routers/weekview.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 856c843...f7178f2. Read the comment docs.

Copy link
Member

@yammesicka yammesicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! I've added few insights :)

requirements.txt Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
tests/test_a_telegram_asyncio.py Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
Copy link
Member

@yammesicka yammesicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! We're ready to merge, just please fix the typo :)

README.md Outdated Show resolved Hide resolved
@yammesicka yammesicka merged commit f24b3f5 into PythonFreeCourse:develop Feb 15, 2021
@issac211 issac211 deleted the build/tox branch February 15, 2021 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants