Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Panel - Backend #283

Merged
merged 54 commits into from Feb 25, 2021
Merged

Feature Panel - Backend #283

merged 54 commits into from Feb 25, 2021

Conversation

LiranCaduri
Copy link
Contributor

@LiranCaduri LiranCaduri commented Feb 14, 2021 •
edited

Feature Panel for Pylender system.

Frontend integration by: @aviadamar in #284.

Bring a decorator to control access to features.

@LiranCaduri
add models to db
d09b5fd
@LiranCaduri
figure out delete.
013c6d5
@LiranCaduri
Merge branch 'develop' of https://github.com/PythonFreeCourse/calendar …
894f234 
…into feature/feature-panel
@LiranCaduri
first structure of route with middlewere
cb7947c
@LiranCaduri
Merge branch 'develop' of https://github.com/PythonFreeCourse/calendar …
523c01e 
…into feature/feature-panel
@LiranCaduri
try middleware
572036e
@LiranCaduri
add middleware filtering requests
397cee3
@LiranCaduri
add: get_user_disabled_features and get_user_enabled_features
1da1dda
@LiranCaduri
modify middleware
d160605
@LiranCaduri
replace testclient, add on startup event, feature folder, is_feature_…
b51cd21 
…exist_in_db function done, and more ..
@LiranCaduri
Merge branch 'develop' of https://github.com/PythonFreeCourse/calendar …
9df777b 
…into feature/feature-panel
@LiranCaduri
improved is_feature_enabled and middleware code.
e4a817a
@LiranCaduri
add_feature_to_user function
0514121
@LiranCaduri
add checking for duplicates in association table
c715299
@LiranCaduri
renaming some files, and adding on and off routes
6380a8c
@LiranCaduri
Merge branch 'develop' of https://github.com/PythonFreeCourse/calendar …
7f50cc0 
…into feature/feature-panel
@LiranCaduri
.example
2ea61cb
@LiranCaduri
split to internal
b2b839f
@LiranCaduri
Merge branch 'develop' of https://github.com/PythonFreeCourse/calendar …
36af9b7 
…into feature/feature-panel
@LiranCaduri
add config
8c4929c
@LiranCaduri
add tests
b999bc6
@LiranCaduri
Merge branch 'develop' of https://github.com/PythonFreeCourse/calendar …
e97f29b 
…into feature/feature-panel
@LiranCaduri
access decorator, back to fastapi testclient, fix tests, new document…
6220ad0 
…ation in index.py
@LiranCaduri
Merge branch 'develop' of https://github.com/PythonFreeCourse/calendar …
f6a6630 
…into feature/feature-panel
@LiranCaduri
fix flake8 issue
0b27713
yammesicka
yammesicka requested changes Feb 17, 2021
View reviewed changes
app/features/index.py Outdated Show resolved Hide resolved
app/features/utils.py Outdated Show resolved Hide resolved
app/internal/features.py Show resolved Hide resolved
app/internal/features.py Outdated Show resolved Hide resolved
app/internal/features.py Outdated Show resolved Hide resolved
app/routers/features.py Outdated Show resolved Hide resolved
app/routers/features.py Outdated Show resolved Hide resolved
app/routers/features.py Outdated Show resolved Hide resolved
tests/client_fixture.py Outdated Show resolved Hide resolved
tests/test_agenda_route.py Outdated Show resolved Hide resolved
Gonzom
Gonzom reviewed Feb 17, 2021
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
app/features/index.py Outdated Show resolved Hide resolved
app/routers/features.py Outdated Show resolved Hide resolved
tests/test_feature_panel.py Outdated Show resolved Hide resolved
tests/test_feature_panel.py Outdated Show resolved Hide resolved
tests/test_feature_panel.py Outdated Show resolved Hide resolved
tests/test_feature_panel.py Outdated Show resolved Hide resolved
yammesicka
yammesicka reviewed Feb 23, 2021
View reviewed changes
Copy link
Member

@yammesicka yammesicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! I've added few insights :)

app/routers/features.py Outdated Show resolved Hide resolved
app/routers/features.py Outdated Show resolved Hide resolved
app/routers/features.py Outdated Show resolved Hide resolved
app/routers/features.py Outdated Show resolved Hide resolved
app/internal/features.py Outdated Show resolved Hide resolved
yammesicka
yammesicka requested changes Feb 23, 2021
View reviewed changes
Copy link
Member

@yammesicka yammesicka left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added few insights.
Try to minimize the amount of queries you run against the database - it's expansive :)

app/internal/features.py Outdated Show resolved Hide resolved
app/internal/features.py Outdated Show resolved Hide resolved
app/internal/features.py Outdated Show resolved Hide resolved
app/internal/features.py Outdated Show resolved Hide resolved
app/internal/features.py Outdated Show resolved Hide resolved
app/internal/features.py Outdated Show resolved Hide resolved
IdanPelled
IdanPelled reviewed Feb 24, 2021
View reviewed changes
Copy link
Contributor

@IdanPelled IdanPelled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great code, good luck!

app/internal/features.py Outdated Show resolved Hide resolved
app/internal/features.py Outdated Show resolved Hide resolved
app/internal/features.py Outdated Show resolved Hide resolved
yammesicka
yammesicka requested changes Feb 24, 2021
View reviewed changes
app/internal/features.py Show resolved Hide resolved
app/internal/features.py Outdated Show resolved Hide resolved
app/internal/features.py Outdated Show resolved Hide resolved
app/internal/features.py Outdated Show resolved Hide resolved
app/internal/features.py Outdated Show resolved Hide resolved
app/routers/google_connect.py Outdated Show resolved Hide resolved
yammesicka
yammesicka requested changes Feb 25, 2021
View reviewed changes
Copy link
Member

@yammesicka yammesicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yalla, almost done

app/internal/features.py Outdated
# route that gived by to the request.
return True

user_ptef = session.query(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is ptef?

app/internal/features.py Show resolved Hide resolved
@yammesicka yammesicka merged commit 66c9fdf into PythonFreeCourse:develop Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yammesicka yammesicka yammesicka requested changes

@ivarshav ivarshav ivarshav left review comments

@Gonzom Gonzom Gonzom left review comments

@IdanPelled IdanPelled IdanPelled left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@LiranCaduri @codecov-io @yammesicka @ivarshav @Gonzom @IdanPelled