Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvements #35

Merged
merged 1 commit into from
Jul 6, 2022
Merged

Performance improvements #35

merged 1 commit into from
Jul 6, 2022

Conversation

jaapieaapie1
Copy link
Contributor

There is no need to check every single movement since the worldguard API doesn't give different results on sub block values it rounds them.

@Sidpatchy Sidpatchy merged commit 01832d6 into PyvesB:master Jul 6, 2022
@Sidpatchy
Copy link
Collaborator

Thanks for the contribution!

@mibby
Copy link

mibby commented Jul 28, 2022

@Sidpatchy I believe this change might be having negative consequences. Tested with the PR reverted and the problem still occurs, so opening a ticket for tracking.

If a person has flight enabled in one dimension and enters another dimension not touching the ground, they are allowed to keep flight on despite being disabled in that world.

i.e.

world - flight allowed
world_nether - flight disallowed

  • Player enters nether portal from overworld flying / floating in the air.
  • Player is put in nether dimension floating since it does not dimension change you on the ground but rather the exact center of the portal location.
  • Player can fly around the nether. Flight does not get disabled by AntiWorldFly.
  • If the player touches the ground, they cannot re-enable flight.

If you don't want to check every single movement for performance reasons, solution may be to add a check for setting flight status on dimension / world change if that world is disallowed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants