forked from Powerarena-Limited/superset
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: ensure that users viewing chart does not automatically save edit…
… data (apache#16077) * add last_change_at migration * add last_saved_by db migration * finish rest of api migration * run precommit * fix name * run precommitt * remove unused mods * merge migrations * Update superset/migrations/versions/6d20ba9ecb33_add_last_saved_at_to_slice_model.py Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> * Update superset/migrations/versions/6d20ba9ecb33_add_last_saved_at_to_slice_model.py Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> * Update superset/migrations/versions/f6196627326f_update_chart_permissions.py Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> * fix test * precommit * remove print * fix test * change test * test commit * test 2 * test 3 * third time the charm * fix put req Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
- Loading branch information
1 parent
c3fa89e
commit 929f41f
Showing
10 changed files
with
150 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66 changes: 66 additions & 0 deletions
66
superset/migrations/versions/6d20ba9ecb33_add_last_saved_at_to_slice_model.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
"""add_last_saved_at_to_slice_model | ||
Revision ID: 6d20ba9ecb33 | ||
Revises: ('ae1ed299413b', 'f6196627326f') | ||
Create Date: 2021-08-02 21:14:58.200438 | ||
""" | ||
|
||
# revision identifiers, used by Alembic. | ||
revision = "6d20ba9ecb33" | ||
down_revision = ("ae1ed299413b", "f6196627326f") | ||
|
||
import sqlalchemy as sa | ||
from alembic import op | ||
from sqlalchemy.dialects import postgresql | ||
|
||
|
||
def upgrade(): | ||
with op.batch_alter_table("slices") as batch_op: | ||
batch_op.add_column(sa.Column("last_saved_at", sa.DateTime(), nullable=True)) | ||
batch_op.add_column(sa.Column("last_saved_by_fk", sa.Integer(), nullable=True)) | ||
batch_op.create_foreign_key( | ||
"slices_last_saved_by_fk", "ab_user", ["last_saved_by_fk"], ["id"] | ||
) | ||
|
||
# now do data migration, copy values from changed_on and changed_by | ||
slices_table = sa.Table( | ||
"slices", | ||
sa.MetaData(), | ||
sa.Column("changed_on", sa.DateTime(), nullable=True), | ||
sa.Column("changed_by_fk", sa.Integer(), nullable=True), | ||
sa.Column("last_saved_at", sa.DateTime(), nullable=True), | ||
sa.Column("last_saved_by_fk", sa.Integer(), nullable=True), | ||
) | ||
conn = op.get_bind() | ||
conn.execute( | ||
slices_table.update().values( | ||
last_saved_at=slices_table.c.changed_on, | ||
last_saved_by_fk=slices_table.c.changed_by_fk, | ||
) | ||
) | ||
# ### end Alembic commands ### | ||
|
||
|
||
def downgrade(): | ||
with op.batch_alter_table("slices") as batch_op: | ||
batch_op.drop_constraint("slices_last_saved_by_fk", type_="foreignkey") | ||
batch_op.drop_column("last_saved_by_fk") | ||
batch_op.drop_column("last_saved_at") | ||
# ### end Alembic commands ### |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters