Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate and fix KILL command behavior #34

Closed
mkilgore opened this issue May 5, 2022 · 0 comments · Fixed by #419
Closed

Investigate and fix KILL command behavior #34

mkilgore opened this issue May 5, 2022 · 0 comments · Fixed by #419
Assignees
Labels
bug Something isn't working

Comments

@mkilgore
Copy link
Contributor

mkilgore commented May 5, 2022

In #19 Steve was having troubles getting KILL to work with files that had spaces in the name. Based on the description of KILL here it seems like it should work if file names have spaces, but the C++ implementation sub_kill() looks fairly questionable and should be reviewed.

At the very least there is a clear difference between the Linux and Windows implementations because Windows uses FindFirstFile() which supposedly handles the * and ? wildcards, but Linux just uses remove() which does not. Additionally, there is a lot of weird/suspicious path handling in Windows that might have been what was giving Steve some trouble. Certainly DeleteFile() itself can handle spaces in paths.

IMO it would probably be worth just implementing the * and ? handling ourselves and use the same implementation for all platforms. That should hopefully also allow us to toss some of the weirder handling and get consistent behavior. We should also presumably verify the behavior of QuickBasic 4.5 a bit

@mkilgore mkilgore added the bug Something isn't working label May 5, 2022
@mkilgore mkilgore added this to Backlog in Backlog/In Progress via automation May 5, 2022
@a740g a740g self-assigned this Dec 28, 2023
@a740g a740g closed this as completed in #419 Jan 2, 2024
Backlog/In Progress automation moved this from Backlog to Done Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

2 participants