Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup_lnx.sh calls make clean without supply OS #89

Closed
mkilgore opened this issue May 31, 2022 · 0 comments · Fixed by #131
Closed

setup_lnx.sh calls make clean without supply OS #89

mkilgore opened this issue May 31, 2022 · 0 comments · Fixed by #131
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Backlog/In Progress

Comments

@mkilgore
Copy link
Contributor

Fairly simple, the Makefile gives an error if it is called without supplying the OS parameter, and ./setup_lnx.sh is doing that when it calls make clean. We simply need to put a OS=lnx on the call.
@mkilgore mkilgore added bug Something isn't working good first issue Good for newcomers labels May 31, 2022
@mkilgore mkilgore added this to Backlog in Backlog/In Progress May 31, 2022
GeorgeMcGinn added a commit to GeorgeMcGinn/QB64pe that referenced this issue Jul 23, 2022
@GeorgeMcGinn
Update setup_lnx.sh
1787877 
Added OS=lnx to the 'make clean' statement for Issue QB64-Phoenix-Edition#89
@GeorgeMcGinn GeorgeMcGinn mentioned this issue Jul 23, 2022
Merged
GeorgeMcGinn added a commit to GeorgeMcGinn/QB64pe that referenced this issue Jul 23, 2022
@GeorgeMcGinn
Update setup_lnx.sh
289c0d1 
Added the OS=lnx to the 'make clean' in response to issue QB64-Phoenix-Edition#89
@mkilgore mkilgore linked a pull request Jul 24, 2022 that will close this issue
Update setup_lnx.sh #131
Merged
Backlog/In Progress automation moved this from Backlog to Done Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Backlog/In Progress
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update setup_lnx.sh GeorgeMcGinn/QB64pe
1 participant
@mkilgore