Fix compilation of files with $ in the name #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RhoSigma-QB64
approved these changes
Jun 10, 2022
This is a bit of an odd one, but files with $ in the name don't compile correctly due to expansion being done on the $. The culprit here is `make`, as the syntax '$x' is interpreted to mean to insert the expansion of the variable 'x'. To avoid this behavior we have to replace every single $ with $$. Make will interpret the $$ to mean it should insert a single $ and not do any expansion, which is what we want. Fixes: QB64-Phoenix-Edition#96
mkilgore
force-pushed
the
fix-dollarsign-files
branch
from
048b82e
to
d36edad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of an odd one, but files with $ in the name don't compile
correctly due to expansion being done on the $.
The culprit here is
make, as the syntax '$x' is interpreted to mean toinsert the expansion of the variable 'x'. To avoid this behavior we have
to replace every single $ with
$$. Make will interpret the$$to mean itshould insert a single $ and not do any expansion, which is what we
want.
Fixes: #96