Fix timers at program start, TIMER STOP, and Sleep with console #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkilgore
force-pushed
the
fix-timer-first-run
branch
from
ef1c39b
to
f115d92
Compare
|
This is ready to be reviewed :) |
a740g
approved these changes
Feb 7, 2023
Timer's were not firing at the right time if they were started shortly after the program started, instead they would fire at twice the interval time (and then work correctly after that). The issue was a mistaken assumption about `time_now`, with the idea that if `last_time == 0` then `time_now` will be large enough such that the interval check will pass. This is wrong because in most cases `time_now` starts at zero at program start, so when `last_time == 0` it will take one full interval of the timer before `time_now` is large enough for the interval check to pass (at which point the timer is initialized and runs normally). This simply refactors the timer logic so that `last_time == 0` is checked first, rather than if the interval has expired. This doesn't change how the normal logic works, but ensures that the value of `time_now` does not matter for initializing a timer. Fixes: QB64-Phoenix-Edition#273
The command Sleep is supposed to allow timers to trigger while the program is sleeping on the delay. This is achieved in QB64 by having commands that do delays manually call evnt() to trigger events if they come up (of which timers are one). Sleep has a custom implementation for console programs on Windows which doesn't do this, so I redid the logic so that it calls evnt() at regular intervals while waiting for input. Additionally, due to now calling evnt() we also need to check if we should exit sleep early due to an evnt() firing. Fixes: QB64-Phoenix-Edition#294
If a timer expires while stopped, it should trigger when TIMER ON is run. Instead, on QB64 it triggers randomly after the TIMER ON happens. The basic issue is that `qbevent` needs to be set to trigger the timer, but TIMER ON doesn't do that. The regular timer logic that does that already set it when the timer expired while sleeping, so it won't set it again. The simplest solution is to just alway set qbevent = 1 when TIMER ON is done. It's slightly less efficent but doesn't hurt to set it even when there are no timers that expired. Fixes: QB64-Phoenix-Edition#293
mkilgore
force-pushed
the
fix-timer-first-run
branch
from
f115d92
to
d4ed371
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three timer-related fixes in here:
last_time == 0logic, which was done after check if the interval had passed. This doesn't work correctly at program start whentime_now == 0. It's not necessary to check the interval anyway (we're just going to reset it), so we can just check for thelast_time == 0special case first and avoid the issue.TIMER STOP, it wouldn't trigger whenTIMER ONis used. This was simple to fix,TIMER ONwasn't settingqbevent = 1to tell the program to check for events (like timer expiration). This meant the timer wouldn't trigger until something else setqbevent.Sleepwith a console program on Windows won't run timers while sleeping. This was due to the custom sleep logic not callingevnt(). I rewrote it to sleep for short intervals and then callevnt()to handle timers and such, like all the other sleep commands do.Fixes: #273
Fixes: #294
Fixes: #293