Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font fixes #503

Merged
merged 8 commits into from
Jun 6, 2024
Merged

Font fixes #503

merged 8 commits into from
Jun 6, 2024

Conversation

a740g
Copy link
Contributor

@a740g a740g commented Jun 5, 2024

This PR:

  • Resolves an issue where the underscore was being clipped in text rendered using _UPRINTSTRING and fonts like DejaVuSansMono.ttf and Times.ttf
  • Allows _UPRINTSTRING to render directly to an image, which can be specified as an optional argument
  • Simplifies the handling of UTF32 strings by utilizing the standard C++ library and enhances the handling of UTF-16 LE/BE

@a740g a740g added bug Something isn't working enhancement New feature or request labels Jun 5, 2024
@a740g a740g self-assigned this Jun 5, 2024
RhoSigma-QB64
RhoSigma-QB64 approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@RhoSigma-QB64 RhoSigma-QB64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wiki updated regarding new image parameter?

@a740g
Copy link
Contributor Author

a740g commented Jun 6, 2024

Wiki updated regarding new image parameter?

I'll make the changes soon.

@a740g a740g merged commit dae5749 into QB64-Phoenix-Edition:main Jun 6, 2024
4 checks passed
@a740g a740g deleted the font-kern-y-test branch June 6, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveMcNeill SteveMcNeill SteveMcNeill approved these changes

@RhoSigma-QB64 RhoSigma-QB64 RhoSigma-QB64 approved these changes

@grymmjack grymmjack Awaiting requested review from grymmjack

@mkilgore mkilgore Awaiting requested review from mkilgore

@flukiluke flukiluke Awaiting requested review from flukiluke

Assignees

@a740g a740g

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@a740g @SteveMcNeill @RhoSigma-QB64