Call start_all_logging on qcodes import
#1850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1850 +/- ##
==========================================
- Coverage 70.38% 70.37% -0.01%
==========================================
Files 152 152
Lines 18859 18875 +16
==========================================
+ Hits 13273 13283 +10
- Misses 5586 5592 +6 |
|
This PR is ready for review. I have, however, not figured out how the cyclic import works: |
astafan8
reviewed
Dec 5, 2019
There was a problem hiding this comment.
@Dominik-Vogel I approve the code, but - could you please add relevant notes to the 15minutesOfQcodes notebook? and, perhaps, to the logging notebook(s)?
astafan8
approved these changes
Dec 5, 2019
jenshnielsen
reviewed
Dec 6, 2019
|
@Dominik-Vogel There are some (unintentional i guess) changes to to the docs templates in this pr |
|
Thank you for spotting this. I'll fix it. |
Dominik-Vogel
force-pushed
the
enable_logging_by_default
branch
from
41fa04a
to
9668acc
Compare
jenshnielsen
approved these changes
Dec 9, 2019
jenshnielsen
reviewed
Dec 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the call to
start_all_loggingto theqcodes.__init__file.This PR provide a new option in
qcodesrc.jsonto enable this feature (defaults to false). It will also automatically enabled if a workstation id and location id has been defined.Furthermore, it is tested if we are in a pytest session. It is bad practice to change anything dependent on whether it is a test situation (this lesson we learned from an anonymous automobile company). Here one could argue that we have not been testing with logging enabled in any case, so that the effective behavior is not altered.
I checked if the logging was triggered by pylint and mypy. Neither do trigger logging.
I tried to incorporate Jens suggestion about marking the test environment in conftest.py, but this failed because qcodes gets imported before entering conftest.
I added a condition for the instrumentation key and refactored the pr.