Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for R&S ZNB-40 #2029

Merged
merged 4 commits into from
Jun 2, 2020
Merged

Add support for R&S ZNB-40 #2029

merged 4 commits into from
Jun 2, 2020

Conversation

mgunyho
Copy link
Contributor

@mgunyho mgunyho commented Jun 1, 2020

This PR adds parameter limits for the R&S ZNB-40 VNA, and also some minor fixes.

@astafan8

@codecov
Copy link

codecov bot commented Jun 1, 2020

Codecov Report

Merging #2029 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2029   +/-   ##
=======================================
  Coverage   71.13%   71.13%           
=======================================
  Files         145      145           
  Lines       19499    19499           
=======================================
  Hits        13870    13870           
  Misses       5629     5629           

Copy link
Collaborator

@jenshnielsen jenshnielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, In the future please don't make unrelated style changes when adding a feature

@jenshnielsen jenshnielsen merged commit 8fcb2c4 into microsoft:master Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants