Improved error handling of B1500 driver #2041
Merged
+39
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenshnielsen
approved these changes
Jun 10, 2020
astafan8
reviewed
Jun 11, 2020
Codecov Report
@@ Coverage Diff @@
## master #2041 +/- ##
==========================================
+ Coverage 71.29% 71.34% +0.05%
==========================================
Files 149 149
Lines 19945 19938 -7
==========================================
+ Hits 14220 14225 +5
+ Misses 5725 5713 -12 |
astafan8
reviewed
Jun 11, 2020
Co-authored-by: Mikhail Astafev <astafan8@gmail.com>
astafan8
approved these changes
Jun 11, 2020
|
remember to backport this to the release branch |
|
I created a label for that in case there are more |
The test passed. We successfully ran a measurement protocol. Also, did some tests to check if the error message is thrown with wrong settings. Good to go! |
This was referenced Jun 18, 2020
astafan8
added a commit
that referenced
this pull request
Jun 22, 2020
Improved error handling of B1500 driver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each time a parameter is set the instrument is queried for errors. If an error is found user is presented with a runtime error with an error message.