Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved error handling of B1500 driver #2041

Merged
merged 8 commits into from
Jun 11, 2020
Merged

Improved error handling of B1500 driver #2041

merged 8 commits into from
Jun 11, 2020

Commits on Jun 10, 2020

  1. Fix No error test message

    @lakhotiaharshit
    lakhotiaharshit committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    2d5e904 View commit details
    Browse the repository at this point in the history

  2. Edit write method to ask for error message every time

    @lakhotiaharshit
    lakhotiaharshit committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    3873230 View commit details
    Browse the repository at this point in the history

  3. use super directly in the method

    @lakhotiaharshit
    lakhotiaharshit committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    c77c8f6 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2020

  1. Instead of 1 it has 3 call. 2 extra for error_message

    @lakhotiaharshit
    lakhotiaharshit committed Jun 11, 2020
    Configuration menu
    Copy the full SHA
    6cba794 View commit details
    Browse the repository at this point in the history

  2. Add "FL 1" in yaml file so that no command error is thrown

    @lakhotiaharshit
    lakhotiaharshit committed Jun 11, 2020
    Configuration menu
    Copy the full SHA
    3f44de3 View commit details
    Browse the repository at this point in the history

  3. add '+' to command error also 

    Co-authored-by: Mikhail Astafev <astafan8@gmail.com>
    @lakhotiaharshit @astafan8
    lakhotiaharshit and astafan8 committed Jun 11, 2020
    Configuration menu
    Copy the full SHA
    1d8d9c2 View commit details
    Browse the repository at this point in the history

  4. Setup functions do not need to check for errors now.

    @lakhotiaharshit
    lakhotiaharshit committed Jun 11, 2020
    Configuration menu
    Copy the full SHA
    766c294 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into b1500_error

    @astafan8
    astafan8 committed Jun 11, 2020
    Configuration menu
    Copy the full SHA
    8df976f View commit details
    Browse the repository at this point in the history