Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qcodes notebook update for Ithaco #2408

Merged
merged 9 commits into from
Nov 10, 2020
Merged

Qcodes notebook update for Ithaco #2408

merged 9 commits into from
Nov 10, 2020

Conversation

FarBo
Copy link
Contributor

@FarBo FarBo commented Nov 6, 2020

  1. Itacho notebook update
  2. Created a folder in the driver_examples to host files needed to be imported in the notebooks.

@codecov
Copy link

codecov bot commented Nov 6, 2020 •
edited
Loading

Codecov Report

Merging #2408 (3e3849f) into master (ee5e730) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2408   +/-   ##
=======================================
  Coverage   62.29%   62.29%           
=======================================
  Files         200      200           
  Lines       26275    26275           
=======================================
+ Hits        16368    16369    +1     
+ Misses       9907     9906    -1

@FarBo FarBo marked this pull request as ready for review November 7, 2020 09:57
@FarBo
Copy link
Contributor Author

FarBo commented Nov 9, 2020

@jenshnielsen
Could you review this?

@FarBo FarBo changed the title Qcodes notebook update Qcodes notebook update for Ithaco Nov 9, 2020
@jenshnielsen
Copy link
Collaborator

Left a few comments inline. I have created a pr to resolve the issue that prevents you from measureing curr dirrectly.

Other than that I suggest that we rename files to static_files to make it more clear what this folder is.
It would be nice if one could see from the image where the wires go and what is connected to what.

@FarBo
Copy link
Contributor Author

FarBo commented Nov 9, 2020

Thanks @jenshnielsen for the correction and the related PR. Then, I will make all amendments based on your PR and other comments and push it

@github-actions github-actions bot merged commit 108ddff into microsoft:master Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenshnielsen jenshnielsen jenshnielsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FarBo @jenshnielsen