Add checks for signal current level and voltage level queries in Keysight E4980A driver #2561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2561 +/- ##
==========================================
+ Coverage 63.60% 63.75% +0.15%
==========================================
Files 198 198
Lines 25929 25946 +17
==========================================
+ Hits 16493 16543 +50
+ Misses 9436 9403 -33 |
jenshnielsen
reviewed
Jan 4, 2021
if you pass an initial value this needs to be sent to the instrument the current sim file does not implement this command so an error will be raised
Fix tests for keysight_e4980a
|
@astafan8 do you want to have the honors of doing the final review |
astafan8
approved these changes
Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
To Do: