-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: hdf5 formatter with json metadata #445
Feature: hdf5 formatter with json metadata #445
Conversation
492afca
to
5631b07
Compare
@AdriaanRol @jenshnielsen The build system is complaining about the type of the arguments of https://github.com/VandersypenQutech/Qcodes/blob/feat/hdf5json/qcodes/data/hdf5_format.py#L239 The |
IMHO this is not a big issue as I understand it
but I fail to see how this archives anything other than make the linter happy |
@jenshnielsen I made the linter happy. Long term fix would be to specifiy the arguments of |
Author: peendebak <P.T.eendebak@tudelft.nl> feat: add hdf5 formatter with json metadata (#445)
This PR adds a new formatters that uses the HDF5 formatter as a base. The metadata is written in plain JSON. In this way the data read back from the metadata is identical to the original data (for all common data types).
@AdriaanRol @Unga @core