DataSet.get_metadata to return value only if the casing of the tag matches the column name in the database #4658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenshnielsen
approved these changes
Sep 27, 2022
…not exactly as in the database
…one if the casing of the given tag is not exact as in the database
astafan8
changed the title
astafan8
changed the title
Codecov Report
@@ Coverage Diff @@
## master #4658 +/- ##
==========================================
+ Coverage 68.23% 68.26% +0.03%
==========================================
Files 339 339
Lines 31781 31794 +13
==========================================
+ Hits 21685 21704 +19
+ Misses 10096 10090 -6 |
jenshnielsen
approved these changes
Sep 27, 2022
|
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataSet.get_metadatamethod for retrieving a metadata value for agiven tag is now case-sensitive with respect to the tag.
For example, if metadata was added with
dataset.add_metadata('something', 1),it can only be retrieved by using its exact casing of the tag,
dataset.get_metadata('something'), and not e.g.dataset.get_metadata('SomeThinG'). In the previous versions of QCoDeS,any casing of the tag in
DataSet.get_metadatawould work and return thevalue stored under that tag. Note that this change brings consistency
with how getting metadata via the
dataset.metadataworks:dataset.metadata['something']does return the value, anddataset.metadata['SomeThinG']does not.Also adds extra testing for
one()helper function and clarifies docstrings of a few helper functions.