Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SignalCore driver #114

Merged
merged 10 commits into from
Jan 7, 2022
Merged

Add SignalCore driver #114

merged 10 commits into from
Jan 7, 2022

Conversation

edumur
Copy link
Contributor

@edumur edumur commented Jan 6, 2022

All in the title I guess ^^ .

@edumur
Copy link
Contributor Author

edumur commented Jan 6, 2022

That's interesting, mypy passed on my laptop:

python -m mypy --ignore-missing-import --no-warn-unused-ignores -p qcodes_contrib_drivers
Success: no issues found in 156 source files

@astafan8
Copy link
Contributor

astafan8 commented Jan 6, 2022

That's interesting, mypy passed on my laptop:

likely because you have Windows? and the CI is using linux. mypy understands platform differences so we can fix it, let me find out how ....

@edumur
Copy link
Contributor Author

edumur commented Jan 6, 2022

Well, I tried my best (can't make local test first)

@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2022

Codecov Report

Merging #114 (6438011) into master (af6ec17) will decrease coverage by 0.24%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
- Coverage   20.06%   19.82%   -0.25%     
==========================================
  Files         120      121       +1     
  Lines       14568    14702     +134     
==========================================
- Hits         2923     2914       -9     
- Misses      11645    11788     +143     
Impacted Files Coverage Δ
...s_contrib_drivers/drivers/SignalCore/SignalCore.py 0.00% <0.00%> (ø)
qcodes_contrib_drivers/_version.py 43.36% <0.00%> (-3.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af6ec17...6438011. Read the comment docs.

@edumur
Copy link
Contributor Author

edumur commented Jan 7, 2022

ok, I am out of ideas...
Does someone has a hint?

@astafan8 astafan8 changed the title Add signal core driver Add SignalCore driver Jan 7, 2022
@astafan8 astafan8 merged commit b6b5a6c into QCoDeS:master Jan 7, 2022
@edumur
Copy link
Contributor Author

edumur commented Jan 7, 2022

Well, great thank for all that work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants