-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update datasets library to 2.2.2 in requirements #664
Merged
jxmorris12
merged 2 commits into
QData:master
from
VijayKalmath:Upgrade-requirements_for_datasets2_2_2
Jun 20, 2022
Merged
Update datasets library to 2.2.2 in requirements #664
jxmorris12
merged 2 commits into
QData:master
from
VijayKalmath:Upgrade-requirements_for_datasets2_2_2
Jun 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Textattack currently installs datasets 1.15 which is far behind the latest datasets library. This commit sets datasets to 2.2.2 in requirments.txt and updates test cases to suit the default imdb dataset using in datasets 2.2.2.
Sorry, but the three skipped examples feels a bit odd, doesn't it? For a model with >80% accuracy, that's pretty unlikely that it gets three wrong back-to-back. |
jxmorris12
reviewed
Jun 9, 2022
Adding Model Evaluations of cnn-imdb and lstm-imdb on imdb datasets across the 2 versions of the datasets package. Datasets - 1.15 ; huggingface-hub-0.0.19
Datasets - 2.2.2; huggingface-hub-0.7.0
|
hope the tests can pass now! |
LGTM! Thanks for doing this, we needed it. |
jxmorris12
approved these changes
Jun 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Summary
Textattack currently installs
datasets 1.15
while installing textattack , which is far behind the latest datasets library.This commit sets datasets to
2.2.2
in requirments.txt and updates test cases to suit the default imdb dataset used indatasets 2.2.2
.Additions
Changes
requirements.txt
.tests/sample_outputs/run_attack_from_file.txt
with the new desired output to stay updated with data used bydatasets=2.2.2
.Deletions
Issues Addressed
Fixes #590
Checklist
.rst
file inTextAttack/docs/apidoc
.'