Skip to content
This repository has been archived by the owner on Jun 20, 2022. It is now read-only.

Throw stuff at windows and see what sticks #685

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

jvanstraten
Copy link
Collaborator

No description provided.

@jvanstraten jvanstraten force-pushed the throw-stuff-at-windows-and-see-what-sticks branch from 0c59d16 to c6dcafa Compare February 4, 2021 12:47
@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #685 (c6dcafa) into master (2257d1e) will decrease coverage by 0.34%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #685      +/-   ##
==========================================
- Coverage   88.27%   87.92%   -0.35%     
==========================================
  Files          88       88              
  Lines        9652     9640      -12     
==========================================
- Hits         8520     8476      -44     
- Misses       1132     1164      +32     
Impacted Files Coverage Δ
rust/src/core/common/channel.rs 100.00% <ø> (ø)
rust/src/core/common/error.rs 35.29% <ø> (-7.44%) ⬇️
rust/tests/core.rs 98.42% <ø> (-0.01%) ⬇️
rust/src/bindings/external/common/arb.rs 82.09% <0.00%> (-16.05%) ⬇️
rust/src/bindings/util.rs 84.53% <0.00%> (-3.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2257d1e...62873ed. Read the comment docs.

@jvanstraten jvanstraten force-pushed the throw-stuff-at-windows-and-see-what-sticks branch from 99f97e0 to 0d606bd Compare February 4, 2021 14:22
@jvanstraten
Copy link
Collaborator Author

Despite CI crashing out and hanging all over the place (likely due to replacing the call to strdup() with a null pointer because it doesn't link right on Windows for stupid reasons, because I don't know what else I would've changed for Linux/MacOS, unless it's crossbeam 3.9 vs 4.0 that's doing it), it turns out quite a lot of things stick: ipc-channel seems to work sufficiently. So while this is not at all complete, Windows support seems viable.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant