Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to TXID Digest and Authorizing Data Commitment #66

Merged
merged 2 commits into from
Jun 13, 2023

Conversation

vivek-arte
Copy link

This PR updates the computation of the transaction digest and authorizing data commitment for the issue bundle to be in line with the specification in ZIP 227.

@what-the-diff
Copy link

what-the-diff bot commented Jun 1, 2023

PR Summary

  • Updated hash_issue_bundle function
    The function now includes the asset description in its computation for more accurate calculations.
  • New function: hash_issue_bundle_empty
    This new function allows for computing commitments for transactions without shielded inputs or outputs, based on ZIP-227 guidelines, providing a uniform way to handle transaction IDs.

Copy link
Collaborator

@PaulLaux PaulLaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with some comments pending,

src/bundle/commitments.rs Outdated Show resolved Hide resolved
src/bundle/commitments.rs Outdated Show resolved Hide resolved
@vivek-arte vivek-arte merged commit 950b806 into zsa1 Jun 13, 2023
21 checks passed
vivek-arte added a commit to QED-it/zips that referenced this pull request Jun 29, 2023
…mentation (#29)

This makes the changes in ZIP 227 based on [this
comment](QED-it/orchard#66 (comment)).
PaulLaux pushed a commit to QED-it/zips that referenced this pull request Oct 4, 2023
…mentation (#29)

This makes the changes in ZIP 227 based on [this
comment](QED-it/orchard#66 (comment)).
daira pushed a commit to daira/zips that referenced this pull request Feb 7, 2024
…mentation (zcash#29)

This makes the changes in ZIP 227 based on [this
comment](QED-it/orchard#66 (comment)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants