Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more QGIS_REPO to travis: improvements for unit testing - fix #49 #50

Closed
wants to merge 1 commit into from

Conversation

slarosa
Copy link
Contributor

@slarosa slarosa commented Nov 6, 2017

Add more QGIS versions to travis. Basically uses the same configuration of qgis2web plugin for testing.

@coveralls
Copy link

Coverage Status

Coverage decreased (-29.3%) to 24.242% when pulling 67ac26c on slarosa:develop into 0140ab5 on akbargumbira:develop.

@slarosa
Copy link
Contributor Author

slarosa commented Nov 6, 2017

ooops...coverage is not my friend!

@slarosa slarosa force-pushed the develop branch 2 times, most recently from 4be39cd to 59c4547 Compare November 6, 2017 10:51
@coveralls
Copy link

Coverage Status

Coverage decreased (-29.3%) to 24.242% when pulling 59c4547 on slarosa:develop into 0140ab5 on akbargumbira:develop.

@coveralls
Copy link

coveralls commented Nov 6, 2017

Coverage Status

Coverage increased (+1.8%) to 55.337% when pulling d282aad on slarosa:develop into 0140ab5 on akbargumbira:develop.

@slarosa
Copy link
Contributor Author

slarosa commented Nov 6, 2017

ok...now coverage is my friend! :-)

@coveralls
Copy link

coveralls commented Nov 6, 2017

Coverage Status

Coverage increased (+1.8%) to 55.337% when pulling 5a1315f on slarosa:develop into 0140ab5 on akbargumbira:develop.

@akbargumbira
Copy link
Collaborator

akbargumbira commented Nov 6, 2017

@slarosa any reason to use mocked QGIS app for the tests? I intentionally used QGIS testing class to promote @m-kuhn 's work last year. Though Boundless makes another testing framework using docker with QGIS instance inside (so the tests are run against a real QGIS instance) and people start using this last approach more...

@m-kuhn
Copy link

m-kuhn commented Nov 6, 2017

QGIS upstream also uses docker images for testing QGIS 3. This can also be used for plugins (see e.g. https://travis-ci.org/opengisch/projectgenerator), QGIS testing classes are available as well.

@slarosa
Copy link
Contributor Author

slarosa commented Nov 6, 2017

No particular reason, just want to see travis happy :-) against more qgis version!
I will do a PR with docker image for testing as soon as possible taking inspiration from @m-kuhn's hint! Thanks.

@m-kuhn
Copy link

m-kuhn commented Nov 6, 2017

@slarosa

You get extra points if you make a deploy

  • on success of all builds
  • and when it's a tagged release

;)

https://travis-ci.org/opengisch/projectgenerator/builds/281908128

@slarosa
Copy link
Contributor Author

slarosa commented Nov 6, 2017

@m-kuhn and that should be an awesome score for my unit-testing game! :-p

@akbargumbira
Copy link
Collaborator

akbargumbira commented Nov 6, 2017

@m-kuhn is there docker image for QGIS 3?

@slarosa more extra points if there is a QGIS 3 image and we also test it against this version :) @elpaso started some work to port this to be ready for QGIS 3 as a core plugin in this branch: https://github.com/akbargumbira/qgis_resources_sharing/tree/qgis3, but I haven't got time to finish it

@m-kuhn
Copy link

m-kuhn commented Nov 6, 2017

@m-kuhn is there docker image for QGIS 3?

The one from the link above is qgis3.

One of the two does not change (fixed to a certain commit) the other one regularly gets updated to the latest master.

@slarosa
Copy link
Contributor Author

slarosa commented Nov 6, 2017

@slarosa any reason to use mocked QGIS app for the tests? I intentionally used QGIS testing class to promote @m-kuhn 's work last year.

Also, using the QGIS testing module (see slarosa@0abda99) I got a bunch of ImportError (i.e ImportError: No module named qgis_resources_sharing.test.repository_handler.test_handler), but was unclear to me on what could be the reason of the problem there:
https://travis-ci.org/slarosa/qgis_resources_sharing/jobs/297732453

@havatv havatv changed the base branch from develop to master March 4, 2020 14:58
@Guts
Copy link
Contributor

Guts commented Sep 5, 2022

This PR has long lived and tests have been refactored to fit Github Actions in #259.

@Guts Guts closed this Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants