Suggestion

[moffile]

Not sure if you're interested in making any changes at this point, but on line 45 of Turntable.ino there is a hard-coded scale factor of "4.4". This hard-coded value seems to be scaling the number of steps-per-revolution based on the gear ratio of the turntable. This is important, especially if someone is trying to use this code on a turntable that is different from the original design, as not modifying this value correctly ruins the follow-on calculations for number of steps per revolution, and it might be hard for some users to debug why they can't get an exact 360deg revolution from the code. I suggest creating a const for this value and adding a comment to it so that users know to modify this value based on the gear ratio of the turntable they use.

[QLRO]

Hi @moffile ,

Sorry for the very late reply. As you can see, I don't use github often.

I do remember I did some kind of calculations, probably using the gear ratio, but I have forgot the exact steps since it has been some years.

I have added the comment based on your suggestion.

I will leave this issue open. Maybe someone interested can help reproducing the calculations.

Best,

[moffile]

Hey Mate, No worries, wasn't really expecting a reply given how old the project was, just thought any other users that get there (maybe from Thingiverse, like I did) might end up reading it and know what to do. For the simple two gear setup on this turntable, the gear ratio is just the number of driven gear's teeth divided by the number of driving gear's teeth. For example, on the turntable I printed I had 50 teeth on the turntable base, and 10 teeth on the stepper motor gear, so my gear ratio was 50/10 which is 5.0. Thanks for replying and thanks for your work on this neat project. Regards, Leigh

…

________________________________ From: QLRO ***@***.***> Sent: Sunday, 11 September 2022 2:04 AM To: QLRO/AA-Scan ***@***.***> Cc: moffile ***@***.***>; Mention ***@***.***> Subject: Re: [QLRO/AA-Scan] Suggestion (Issue #8) Hi @moffile<https://github.com/moffile> , Sorry for the very late reply. As you can see, I don't use github often. I do remember I did some kind of calculations, probably using the gear ratio, but I have forgot the exact steps since it has been some years. I have added the comment based on your suggestion. I will leave this issue open. Maybe someone interested will help reproducing the calculations. Best, — Reply to this email directly, view it on GitHub<#8 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AXKHT7NWSE2Y7D7B6JV7CQTV5SWPNANCNFSM5MBP7A3A>. You are receiving this because you were mentioned.Message ID: ***@***.***>