-
Notifications
You must be signed in to change notification settings - Fork 137
-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify compile-time complex and real builds as run-time options in a single build #4099
Comments
I suggest to add the runtime option next. Then adapt code starting at the lowest levels of the app that connects to it, as per the other tasks. There are many |
@prckent @ye-luo what would be a good place for a runtime configuration option tracking real, complex, and precision (full, mixed):
|
These are all reasonable candidates. I would suggest ProjectData, but whatever turns out to be not too inconvenient is fine by me. There are a few too many too level objects with not sharply enough defined roles imo. |
Also related to #4062 , which could be split when this is completed. |
Is your feature request related to a problem? Please describe.
Currently QMCPACK separates
real
andcomplex
functionality at compile-time. Thus, stakeholders need to create two separate executables to test, deploy and develop functionality.Describe the solution you'd like
The long term goal is to unify these real/complex compile-time build options into a single build that can take equivalent runtime options.
Describe alternatives you've considered
Since these involve invasive changes in the entire codebase tackling compile-time conditionals e.g.
#ifdef QMC_COMPLEX
, there are a few steps that need to be accounted for. If possible, break down the effort into smaller tasks.#ifdef QMC_COMPLEX
#ifdef QMC_COMPLEX
by a proper variable at theqmcapp.cpp
main level and propagate through theqmcplusplus
namespace. This should not be an invasive and breaking change.Additional context
This issue tracks efforts and discussion related to this integration.
The text was updated successfully, but these errors were encountered: