Fix g(r) for SoA #2035
Merged
Fix g(r) for SoA #2035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SoA version is missing the +1 offset for the pair_id index to the normalization factor.
7 tasks
|
Thanks Mark. By chance, have you thought of a way to test this? Perhaps a deterministic or short run and check of the normalization (large r limit), which should be very robust? |
|
I emailed Josh a couple of days ago and he said he was working on a test. |
Closed
|
I made an issue so that we don't lose track of needing the test. We can revisit when the test is added if needed. |
prckent
approved these changes
Oct 24, 2019
This was referenced Nov 1, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SoA version is missing the +1 offset for the pair_id index to the normalization factor.
Closes #1699