Make catch_main.cpp and avoid redundant compilation #2389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ye-luo
changed the title
ye-luo
changed the title
prckent
approved these changes
Apr 19, 2020
There was a problem hiding this comment.
Quick check for a basket of builds on nitrogen (with the weekly tests still running in the background): 35m22s reduced to 29m39s. Good optimization.
grep -e "Script START" -e "Script END" -e "START build_" -e "tests, passed" out_unit_*
out_unit_dev:--- Script START Sun Apr 19 14:51:19 EDT 2020
out_unit_dev:--- START build_gccnew Sun Apr 19 14:51:20 EDT 2020
out_unit_dev:--- START build_gcccuda Sun Apr 19 14:54:11 EDT 2020
out_unit_dev:--- START build_gcccuda_full Sun Apr 19 14:58:44 EDT 2020
out_unit_dev:--- START build_gcccuda_complex Sun Apr 19 15:01:14 EDT 2020
out_unit_dev:--- START build_gccnew_complex Sun Apr 19 15:03:45 EDT 2020
out_unit_dev:--- START build_gccnew_nompi Sun Apr 19 15:06:47 EDT 2020
out_unit_dev:--- START build_gccnew_nompi_complex Sun Apr 19 15:08:46 EDT 2020
out_unit_dev:--- START build_clangnew Sun Apr 19 15:10:48 EDT 2020
out_unit_dev:--- START build_clangnew_complex Sun Apr 19 15:13:18 EDT 2020
out_unit_dev:--- START build_clangnew_mixed Sun Apr 19 15:16:01 EDT 2020
out_unit_dev:--- START build_clangnew_complex_mixed Sun Apr 19 15:18:35 EDT 2020
out_unit_dev:--- START build_clangnew_aos Sun Apr 19 15:21:21 EDT 2020
out_unit_dev:--- START build_clangnew_complex_aos Sun Apr 19 15:23:55 EDT 2020
out_unit_dev:--- Script END Sun Apr 19 15:26:41 EDT 2020
out_unit_pr:--- Script START Sun Apr 19 15:43:02 EDT 2020
out_unit_pr:--- START build_gccnew Sun Apr 19 15:43:03 EDT 2020
out_unit_pr:--- START build_gcccuda Sun Apr 19 15:45:34 EDT 2020
out_unit_pr:--- START build_gcccuda_full Sun Apr 19 15:47:43 EDT 2020
out_unit_pr:--- START build_gcccuda_complex Sun Apr 19 15:49:54 EDT 2020
out_unit_pr:--- START build_gccnew_complex Sun Apr 19 15:52:12 EDT 2020
out_unit_pr:--- START build_gccnew_nompi Sun Apr 19 15:55:02 EDT 2020
out_unit_pr:--- START build_gccnew_nompi_complex Sun Apr 19 15:56:47 EDT 2020
out_unit_pr:--- START build_clangnew Sun Apr 19 15:58:28 EDT 2020
out_unit_pr:--- START build_clangnew_complex Sun Apr 19 16:00:42 EDT 2020
out_unit_pr:--- START build_clangnew_mixed Sun Apr 19 16:03:10 EDT 2020
out_unit_pr:--- START build_clangnew_complex_mixed Sun Apr 19 16:05:32 EDT 2020
out_unit_pr:--- START build_clangnew_aos Sun Apr 19 16:08:01 EDT 2020
out_unit_pr:--- START build_clangnew_complex_aos Sun Apr 19 16:10:15 EDT 2020
out_unit_pr:--- Script END Sun Apr 19 16:12:41 EDT 2020
prckent
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Merge after #2386, closes #2387
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
bora
Checklist