Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a restart test #249

Merged
merged 3 commits into from Jun 5, 2017
Merged

Add a restart test #249

merged 3 commits into from Jun 5, 2017

Conversation

ye-luo
Copy link
Contributor

@ye-luo ye-luo commented Jun 4, 2017

For issue #232

@qmc-robot
Copy link

Can one of the maintainers verify this patch?

1 similar comment
@qmc-robot
Copy link

Can one of the maintainers verify this patch?

@markdewing
Copy link
Contributor

okay to test

@prckent
Copy link
Contributor

prckent commented Jun 4, 2017

Will merge Monday afternoon, after allowing others to comment but still ahead of the nightlies running.

Note that these are VMC tests only at this point, an easier case than DMC.

@ye-luo
Copy link
Contributor Author

ye-luo commented Jun 5, 2017

If we define restart as loading the random number and electron configurations. There is no difference between VMC and DMC. If we need to fully check every restart behaviour, it will be hard.

@prckent
Copy link
Contributor

prckent commented Jun 5, 2017

We need to specifically check DMC because restart problems have been observed ( #2 ). We also need to create tests for any functionality that is likely to be refactored or that we will have collaborators work on. Ideally we would have tests for all functionality, but for now we prioritize.

@prckent
Copy link
Contributor

prckent commented Jun 5, 2017

Merging, DMC tests still needed.

@prckent prckent merged commit 63bb56b into QMCPACK:develop Jun 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants