Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nexus: batched driver interface #2901

Merged
merged 14 commits into from
Jun 3, 2021
Merged

Conversation

jtkrogel
Copy link
Contributor

Proposed changes

Expand Nexus capabilities to drive workflows involving legacy and/or batched QMCPACK drivers.

What type(s) of changes does this code introduce?

  • New feature

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

Laptop

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'

@qmc-robot
Copy link

Can one of the admins verify this patch?

@jtkrogel jtkrogel changed the title [WIP] Nexus: batched driver interface Nexus: batched driver interface May 27, 2021
@jtkrogel
Copy link
Contributor Author

This is ready to go now for VMC and DMC.

Having this in now will allow for others to try out both the batched drivers and the Nexus interfaces to them. I've added both a unit test and a user example that reproduces an adjacent example using the legacy drivers.

@ye-luo
Copy link
Contributor

ye-luo commented Jun 3, 2021

Test this please

Copy link
Contributor

@ye-luo ye-luo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ye-luo ye-luo enabled auto-merge June 3, 2021 15:58
@ye-luo ye-luo merged commit 0667ab9 into QMCPACK:develop Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants