Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Andes at OLCF: NEXUS and build scripts #3073

Merged
merged 7 commits into from
Apr 5, 2021
Merged

Conversation

zenandrea
Copy link
Contributor

Please review the developer documentation
on the wiki of this project that contains help and requirements.

Proposed changes

Add Andes to nexus machines.py and add
config/build_olcf_andes.sh
config/load_olcf_andes_modules.sh

Describe what this PR changes and why. If it closes an issue, link to it here
with a supported keyword.

What type(s) of changes does this code introduce?

Delete the items that do not apply

  • Build related changes

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

Andes

Checklist

Update the following with a yes where the items apply. If you're unsure about any of them, don't hesitate to ask. This is
simply a reminder of what we are going to look for before merging your code.

  • Yes. This PR is up to date with current the current state of 'develop'
  • No. Code added or changed in the PR has been clang-formatted
  • No. This PR adds tests to cover any new code, or to catch a bug that is being fixed
  • No. Documentation has been added (if appropriate)

@qmc-robot
Copy link

Can one of the admins verify this patch?

@prckent prckent changed the title Zen Support Andes at OLCF: NEXUS and build scripts Apr 2, 2021
@prckent
Copy link
Contributor

prckent commented Apr 2, 2021

Thanks Andrea. FYI, please ignore the GitHub Actions CI problem.

Have you done much production with these? I assume yes, but it would be good to learn what you found.

Can you also comment on the smt4 change for Summit?

@prckent
Copy link
Contributor

prckent commented Apr 2, 2021

OK to test

nexus/lib/machines.py Outdated Show resolved Hide resolved
@zenandrea
Copy link
Contributor Author

Thanks Andrea. FYI, please ignore the GitHub Actions CI problem.

Have you done much production with these? I assume yes, but it would be good to learn what you found.

Can you also comment on the smt4 change for Summit?

Hi @prckent,
I did not extensively use andes, as I don't have many resources there.
I mostly use andes to prepare the wave function (so, pwscf calculations) and then I use summit.
However, I made a few qmcpack calculations on andes, for cross-checking, and it seems to work well.

Concerning the smt4 change on summit, well, that was unintentional.
I noticed some benefit on some of my calculations, but it is fine also to use smt1.

@prckent prckent self-requested a review April 5, 2021 14:13
Copy link
Contributor

@prckent prckent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Andrea.

Merging ahead of release.

@prckent prckent added this to the v3.11.0 milestone Apr 5, 2021
@prckent
Copy link
Contributor

prckent commented Apr 5, 2021

OK to test

@ye-luo
Copy link
Contributor

ye-luo commented Apr 5, 2021

Test this please

@ye-luo ye-luo merged commit f424d65 into QMCPACK:develop Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants