Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build ppconvert by default #3143

Merged
merged 6 commits into from
Apr 29, 2021
Merged

Build ppconvert by default #3143

merged 6 commits into from
Apr 29, 2021

Conversation

prckent
Copy link
Contributor

@prckent prckent commented Apr 28, 2021

Proposed changes

Per the title, always build ppconvert. Update docs appropriately, remove outdated readme.

What type(s) of changes does this code introduce?

  • Build related changes
  • Documentation changes

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

nitrogen, llvm+openmpi

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'
  • NA. Code added or changed in the PR has been clang-formatted
  • NA. This PR adds tests to cover any new code, or to catch a bug that is being fixed
  • Yes. Documentation has been added (if appropriate)

@prckent
Copy link
Contributor Author

prckent commented Apr 28, 2021

My initial PR tripped a few problems with CUDA related builds and gcc warnings, the latter since the code was never cleaned. Working through them.

@prckent
Copy link
Contributor Author

prckent commented Apr 28, 2021

The Intel 19.1.3.20200925 compiler has no problem with this code, and unfortunately I don't have immediate access to the old 19.0.0 compiler used in the ALCF CI. Since gcc and llvm have no problem, I think we can assume that we have legal code.

@prckent
Copy link
Contributor Author

prckent commented Apr 29, 2021

Results of Intel compiler version bisection below. Used gcc@7.5.0 for c++ library. At least 19.0.3 is required.

19.1.2 GOOD
19.0.5 GOOD
19.0.3 GOOD
19.0.1 (untested, spack unable to fetch)
19.0.0 BAD

@ye-luo
Copy link
Contributor

ye-luo commented Apr 29, 2021

Test this please

1 similar comment
@ye-luo
Copy link
Contributor

ye-luo commented Apr 29, 2021

Test this please

@ye-luo ye-luo enabled auto-merge April 29, 2021 03:01
@ye-luo ye-luo merged commit c251558 into QMCPACK:develop Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants