Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nexus: fix syntax warnings #3497

Merged
merged 2 commits into from
Sep 30, 2021
Merged

Nexus: fix syntax warnings #3497

merged 2 commits into from
Sep 30, 2021

Conversation

jtkrogel
Copy link
Contributor

Proposed changes

More recent python versions now generate syntax warnings (de-linting). Fix the few that exist so as not to scare off users.

What type(s) of changes does this code introduce?

  • Refactoring (no functional changes, no api changes)

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

Workstation

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'

@qmc-robot
Copy link

Can one of the admins verify this patch?

Copy link
Contributor

@prckent prckent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prckent
Copy link
Contributor

prckent commented Sep 30, 2021

This will need a non-ORNL person to merge.

@ye-luo
Copy link
Contributor

ye-luo commented Sep 30, 2021

Test this please

1 similar comment
@prckent
Copy link
Contributor

prckent commented Sep 30, 2021

Test this please

@prckent
Copy link
Contributor

prckent commented Sep 30, 2021

Start testing in-house

@ye-luo ye-luo merged commit a556925 into QMCPACK:develop Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants