Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nexus: Add small fix for custom band plotting #3566

Merged
merged 2 commits into from
Oct 28, 2021

Conversation

mcbennet
Copy link
Contributor

Proposed changes

Fixing small issue in plot_bandstructure when a custom k-path is specified.

What type(s) of changes does this code introduce?

  • Bugfix

Does this introduce a breaking change?

  • No. All nxs-test tests pass

What systems has this change been tested on?

Laptop

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'
  • N/A. Code added or changed in the PR has been clang-formatted
  • No. This PR adds tests to cover any new code, or to catch a bug that is being fixed
  • N/A. Documentation has been added (if appropriate)

@qmc-robot
Copy link

Can one of the admins verify this patch?

@mcbennet mcbennet changed the title Add small fix for custom band plotting Nexus: Add small fix for custom band plotting Oct 28, 2021
Copy link
Contributor

@jtkrogel jtkrogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markdewing
Copy link
Contributor

Test this please

@ye-luo ye-luo enabled auto-merge October 28, 2021 18:30
@ye-luo ye-luo merged commit cd304d2 into QMCPACK:develop Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants